Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-1101 Refactor ProjectImportTask to Kotlin #4329

Closed
wants to merge 1 commit into from
Closed

CATROID-1101 Refactor ProjectImportTask to Kotlin #4329

wants to merge 1 commit into from

Conversation

reichli
Copy link
Contributor

@reichli reichli commented Sep 2, 2021 •
edited

https://jira.catrob.at/browse/CATROID-1101

ProjectImportTask (now ProjectImporter) was refactored to Kotlin and tests were created for it. Additionally tests for the AddItemTouserListAction (leftover from previous ticket CATROID-1068) were also refactored to Kotlin -> boyscouting.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

adnaribo
adnaribo approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@adnaribo adnaribo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@reichli reichli force-pushed the CATROID-1101 branch 4 times, most recently from c83df3e to 78d0972 Compare February 27, 2022 17:27
@adnaribo
Copy link
Contributor

Please resolve conflicts :)

@reichli
CATROID-1101 Refactor ProjectImportTask to Kotlin
0db9e41 
ProjectImportTask (now ProjectImporter) was refactored to using
Coroutines instead of the deprecated AsyncJob and tests were
created for it (unit tests for both the ProjectUnZipperAndImporter
and ProjectImporter as well as an espresso-test). Additionally
tests for the AddItemToUserListAction (leftover from previous
ticket CATROID-1068) were also refactored to Kotlin -> boyscouting.
@reichli
Copy link
Contributor Author

reichli commented Mar 28, 2022

Conflicts are resolved and the branch rebased ontop of the current develop.

@moberer
Copy link
Contributor

moberer commented Jul 5, 2023

Partially obsolete, partially work continues in CATROID-1224

@moberer moberer closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnaribo adnaribo adnaribo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@reichli @adnaribo @moberer