Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAINTROID-95: app name in ActionBar #694

Merged
merged 1 commit into from
Jan 21, 2020
Merged

PAINTROID-95: app name in ActionBar #694

merged 1 commit into from
Jan 21, 2020

Conversation

SebastianGrief
Copy link
Contributor

No description provided.

ThomasSchwengler
ThomasSchwengler requested changes Jul 5, 2019
View reviewed changes
Copy link
Member

@ThomasSchwengler ThomasSchwengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct commit message

ThomasSchwengler
ThomasSchwengler approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@ThomasSchwengler ThomasSchwengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

@mrmattmueller
Copy link
Contributor

Text has the wrong color (black), please also talk about the alignment with Vesna. Thx!

@ThomasSchwengler
Copy link
Member

Text color depends on #682 where the actionbar theme is set to a consistent style

@ThomasSchwengler
Copy link
Member

Please rebase

@wslany wslany merged commit 3691b2a into Catrobat:develop Jan 21, 2020
@wslany
Copy link
Member

wslany commented Jan 21, 2020

Thanks --- hoping for the best...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasSchwengler ThomasSchwengler ThomasSchwengler approved these changes

@VesnaK VesnaK Awaiting requested review from VesnaK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SebastianGrief @mrmattmueller @ThomasSchwengler @wslany