Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAINTROID-100 Increase Min Support to Android 5.0 #708

Merged
merged 1 commit into from
Apr 30, 2020
Merged

PAINTROID-100 Increase Min Support to Android 5.0 #708

merged 1 commit into from
Apr 30, 2020

Conversation

Tscheppe
Copy link
Contributor

@Tscheppe Tscheppe commented Sep 17, 2019 •
edited
Loading

  • Removed TechDept code for older APIs
  • Removed Code that became deprecated in API21

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@Tscheppe Tscheppe force-pushed the PAINTROID-100_Incrase_min_support branch 7 times, most recently from 008d481 to 2ca0051 Compare September 23, 2019 11:57
@ThomasSchwengler
Copy link
Member

ThomasSchwengler commented Oct 9, 2019 •
edited
Loading

Please resolve conflicts

Edit:
Removed comment, as it's not in "In Code Review" yet

@Tscheppe Tscheppe force-pushed the PAINTROID-100_Incrase_min_support branch 2 times, most recently from 3a12b93 to c27c526 Compare April 22, 2020 08:48
@Tscheppe Tscheppe force-pushed the PAINTROID-100_Incrase_min_support branch 2 times, most recently from 53f89b0 to 3c5ae5f Compare April 23, 2020 12:27
SebastianGrief
SebastianGrief approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@SebastianGrief SebastianGrief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslany wslany merged commit 1f302a2 into Catrobat:develop Apr 30, 2020
@wslany
Copy link
Member

wslany commented Apr 30, 2020

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianGrief SebastianGrief SebastianGrief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tscheppe @ThomasSchwengler @wslany @SebastianGrief