Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if build system allows conversion of JavaScript to TypeScript files #1

Open
rubenthoms opened this issue Nov 16, 2020 · 1 comment
Labels
enhancement New feature or request prioritized Issue should be treated prioritized.

Comments

@rubenthoms
Copy link
Collaborator

rubenthoms commented Nov 16, 2020

In order to allow type hints, we need to convert all JavaScript files to TypeScript files. As a prerequisite, the build system must be ensured to support TypeScript. There is a promising how2 here:
https://www.tutorialsteacher.com/typescript/converting-javascript-to-typescript

This has already been partly implemented in equinor#121. It appears the build system was already ready to take in .ts/.tsx files. However, this should be double-checked.

For the original issue see: equinor#77

NOTE: Components that do not need to be converted:

  • LayeredMap (was superseded by LeafletMap)
  • SubsurfaceMap (going to be removed)
@rubenthoms rubenthoms added enhancement New feature or request prioritized Issue should be treated prioritized. labels Nov 16, 2020
@rubenthoms rubenthoms changed the title Convert JavaScript to TypeScript files Check if build system allows conversion of JavaScript to TypeScript files Nov 16, 2020
@anders-kiaer
Copy link

FYI: equinor#77 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prioritized Issue should be treated prioritized.
Projects
None yet
Development

No branches or pull requests

2 participants