Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to typescript #77

Closed
anders-kiaer opened this issue Nov 6, 2019 · 2 comments
Closed

Change to typescript #77

anders-kiaer opened this issue Nov 6, 2019 · 2 comments
Labels
CeeSol Task owned by Ceetron Solutions maintenance
Projects
Webviz

Comments

@anders-kiaer
Copy link
Collaborator

anders-kiaer commented Nov 6, 2019 •
edited
Loading

Similar to equinor/webviz-subsurface#483 in terms of benefits - but here in JavaScript (TypeScript) domain instead. Some initial work was done in #121 in order to change build system to support TypeScript.

If during the type hint work suggestions for repo restructuring are found, these could either be documented as new issues (e.g. large restructuring) or done at the same time (e.g. small restructuring).

Isse #245 (basically 🔪 away code) is suggested done first - as that component is to be removed anyway. Also consider dropping type hints for SubsurfaceMap as that is to be removed (alternatively do #246 before #77).
@anders-kiaer anders-kiaer added question Further information is requested maintenance labels Nov 6, 2019
@anders-kiaer anders-kiaer added this to Being Planned in Webviz Nov 13, 2019
@anders-kiaer anders-kiaer moved this from Backlog to Sprint week 19 in Webviz May 8, 2020
@anders-kiaer anders-kiaer self-assigned this May 8, 2020
@anders-kiaer anders-kiaer mentioned this issue May 11, 2020
Merged
@anders-kiaer anders-kiaer moved this from Sprint week 20 to Backlog in Webviz May 12, 2020
@anders-kiaer anders-kiaer removed their assignment Nov 2, 2020
@anders-kiaer anders-kiaer added CeeSol Task owned by Ceetron Solutions and removed question Further information is requested labels Nov 2, 2020
@anders-kiaer anders-kiaer moved this from Backlog to Prioritized (next in progress) in Webviz Nov 2, 2020
@rubenthoms rubenthoms mentioned this issue Nov 16, 2020
Open
@anders-kiaer
Copy link
Collaborator Author

anders-kiaer commented Nov 19, 2020 •
edited
Loading

We discovered now that Dash itself not yet support TypeScript (plotly/dash#719). I.e. the "top" React components (those exposed to dash-generate-components) might not be possible to convert yet (haven't looked the Dash issue in detail, so might be wrong conclusion)?

@anders-kiaer
Copy link
Collaborator Author

All new components written in TypeScript + transpiling setup implemented for converting TypeScript to React during build (in order to work with Dash).

Webviz automation moved this from Prioritized (next in progress) 🚀 to Done 🏁 Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CeeSol Task owned by Ceetron Solutions maintenance
Projects
Webviz
Archived in project
Webviz
  
Done 🏁
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anders-kiaer