Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TypeScript #121

Merged
merged 1 commit into from
May 12, 2020
Merged

Support TypeScript #121

merged 1 commit into from
May 12, 2020

Conversation

anders-kiaer
Copy link
Collaborator

@anders-kiaer anders-kiaer commented May 11, 2020

Related to #77.

This PR changes the building and linting process, such that it is ready to accept TypeScript and JavaScript, not only JavaScript. This enables a gradual transformation to TypeScript when suitable, which is probably more efficient than transforming all existing code to TypeScript "in one go" (since some components might be totally rewritten anyway, or removed, like LayeredMap).

Also update eslint through two major version releases (which includes some new checks).

@anders-kiaer anders-kiaer added this to In Progress in Webviz May 11, 2020
@anders-kiaer anders-kiaer self-assigned this May 11, 2020
@anders-kiaer anders-kiaer changed the title Change to TypeScript Support TypeScript May 12, 2020
@anders-kiaer anders-kiaer marked this pull request as ready for review May 12, 2020 10:10
@anders-kiaer anders-kiaer moved this from In Progress to In Review in Webviz May 12, 2020
Webviz automation moved this from In Review to Ready for merge May 12, 2020
Copy link
Collaborator

@HansKallekleiv HansKallekleiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anders-kiaer anders-kiaer merged commit 841a2bf into equinor:master May 12, 2020
Webviz automation moved this from Ready for merge to Done May 12, 2020
@anders-kiaer anders-kiaer deleted the typescript branch May 12, 2020 18:51
@anders-kiaer anders-kiaer mentioned this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Webviz
  
Done 🏁
Development

Successfully merging this pull request may close these issues.

None yet

2 participants