Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mypy to CI #3

Closed
rubenthoms opened this issue Nov 13, 2020 · 0 comments
Closed

Add mypy to CI #3

rubenthoms opened this issue Nov 13, 2020 · 0 comments
Assignees
@rubenthoms
Labels
enhancement New feature or request prioritized Issue should be trated prioritized.

Comments

@rubenthoms
Copy link
Collaborator

Mypy is an optional static type checker for Python (http://mypy-lang.org/). Asgeir did already implement it for webviz-config (see equinor/webviz-config#195) and now Equinor does also wish to implement it in the CI for webviz-subsurface (see https://github.com/equinor/webviz-config/blob/8428a68b80e9a310fcef35604cbd2dfd984b4e32/.github/workflows/webviz-config.yml#L73, equinor#483).

It makes sense to start with this implementation since it is going to be a big help for the further implementation of type hints.
@rubenthoms rubenthoms added enhancement New feature or request prioritized Issue should be trated prioritized. labels Nov 13, 2020
@rubenthoms rubenthoms self-assigned this Nov 16, 2020
@rubenthoms rubenthoms mentioned this issue Nov 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rubenthoms rubenthoms

Labels
enhancement New feature or request prioritized Issue should be trated prioritized.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added mypy to ci and to setup.py. CeetronSolutions/webviz-subsurface
1 participant
@rubenthoms