Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python type hints + enable mypy in CI #483

Closed
anders-kiaer opened this issue Nov 2, 2020 · 0 comments · Fixed by #521
Closed

Add Python type hints + enable mypy in CI #483

anders-kiaer opened this issue Nov 2, 2020 · 0 comments · Fixed by #521
Labels
CeeSol Task owned by Ceetron Solutions
Projects
Webviz

Comments

@anders-kiaer
Copy link
Collaborator

anders-kiaer commented Nov 2, 2020 •
edited

Type hints are useful both when reading/understanding the source code, as well as useful to catch bugs upfront during development.

Objective of this issue is to add type hints webviz-subsurface. The corresponding PR in webviz-config is equinor/webviz-config#195, and the CI line there is this one.

If during the type hint work suggestions for repo restructuring are found, these could either be documented as new issues (large restructuring) or done at the same time (small restructuring). See also #464.

More info regarding mypy: https://github.com/python/mypy
@anders-kiaer anders-kiaer added the CeeSol Task owned by Ceetron Solutions label Nov 2, 2020
@anders-kiaer anders-kiaer mentioned this issue Nov 2, 2020
Closed
@anders-kiaer anders-kiaer added this to Prioritized (next in progress) in Webviz Nov 2, 2020
This was referenced Nov 13, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@anders-kiaer anders-kiaer moved this from Prioritized (next in progress) 🚀 to In Progress 🚧 in Webviz Nov 23, 2020
@rubenthoms rubenthoms mentioned this issue Dec 4, 2020
Merged
Webviz automation moved this from In Progress 🚧 to Done 🏁 Dec 8, 2020
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this issue Jul 19, 2022
@alexandruandrei91
Change tsconfig flags to match Webviz Core Components (equinor#483)
b088a31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CeeSol Task owned by Ceetron Solutions
Projects
Webviz
Archived in project
Webviz
  
Done 🏁
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Partially added Python type hints and enabled mypy in CI CeetronSolutions/webviz-subsurface
1 participant
@anders-kiaer