Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type hinting #195

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Added type hinting #195

merged 1 commit into from
Feb 7, 2020

Conversation

asnyv
Copy link
Collaborator

@asnyv asnyv commented Feb 6, 2020

Resolves #187

@anders-kiaer anders-kiaer added this to In Progress in Webviz Feb 7, 2020
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🎉🚀 Some suggestions/feedback below.

webviz_config/_certificate.py Outdated Show resolved Hide resolved
webviz_config/_certificate.py Outdated Show resolved Hide resolved
webviz_config/_certificate.py Outdated Show resolved Hide resolved
webviz_config/_plugin_abc.py Outdated Show resolved Hide resolved
webviz_config/plugins/_banner_image.py Show resolved Hide resolved
webviz_config/plugins/_markdown.py Show resolved Hide resolved
webviz_config/plugins/_table_plotter.py Show resolved Hide resolved
Webviz automation moved this from In Progress to In Review Feb 7, 2020
Webviz automation moved this from In Review to Ready for merge Feb 7, 2020
@asnyv asnyv merged commit 67e6191 into equinor:master Feb 7, 2020
Webviz automation moved this from Ready for merge to Done Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Webviz
  
Done 🏁
Development

Successfully merging this pull request may close these issues.

Use mypy for type annotation linting
2 participants