Normalize point source color #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See Issue CelestiaProject#2016 Pedro noted that old addons use [ 0 0 0 ] in order for object to not get rendered as points; this is handled by the condition at the beginning, which excludes such objects (and so they do not get rendered anyway).
ajtribick
reviewed
Dec 19, 2023
(missing .toVector3() in line 2975)
375gnu
reviewed
Dec 20, 2023
375gnu
reviewed
Dec 20, 2023
apparently just maxCoeff works? Co-authored-by: Hleb Valoshka <375gnu@gmail.com>
375gnu
requested changes
Dec 20, 2023
Co-authored-by: Hleb Valoshka <375gnu@gmail.com>
True, will do that real quick |
Hope I actually properly SAVED the file this time!!!
375gnu
requested changes
Dec 20, 2023
Looks like I accidentally stole the bracket srry
375gnu
reviewed
Dec 20, 2023
Co-authored-by: Hleb Valoshka <375gnu@gmail.com>
|
375gnu
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #2016
Pedro noted that old addons use [ 0 0 0 ] in order for object to not get rendered as points; this is handled by the condition at the beginning, which excludes such objects (and so they do not get rendered anyway).