Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize point source color #2021

Merged
merged 8 commits into from
Dec 23, 2023
Merged

Normalize point source color #2021

merged 8 commits into from
Dec 23, 2023

Commits on Dec 19, 2023

  1. Normalize point source color 

    See Issue CelestiaProject#2016

Pedro noted that old addons use [ 0 0 0 ] in order for object to not get rendered as points; this is handled by the condition at the beginning, which excludes such objects (and so they do not get rendered anyway).
    @JiliTheSpaceboy
    JiliTheSpaceboy committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    b054057 View commit details
    Browse the repository at this point in the history

  2. Normalize point source color: fix 1 

    (missing .toVector3() in line 2975)
    @JiliTheSpaceboy
    JiliTheSpaceboy committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    648343a View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Update src/celengine/render.cpp 

    apparently just maxCoeff works?

Co-authored-by: Hleb Valoshka <375gnu@gmail.com>
    @JiliTheSpaceboy @375gnu
    JiliTheSpaceboy and 375gnu committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    3342353 View commit details
    Browse the repository at this point in the history

  2. Update src/celengine/render.cpp 

    Co-authored-by: Hleb Valoshka <375gnu@gmail.com>
    @JiliTheSpaceboy @375gnu
    JiliTheSpaceboy and 375gnu committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    cc9bf5f View commit details
    Browse the repository at this point in the history

  3. Normalize point source: explanation comments and bracket 'fixing'

    @JiliTheSpaceboy
    JiliTheSpaceboy committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    b6cd625 View commit details
    Browse the repository at this point in the history

  4. Normalize point source: explanation comments and bracket 'fixing' 

    Hope I actually properly SAVED the file this time!!!
    @JiliTheSpaceboy
    JiliTheSpaceboy committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    d345106 View commit details
    Browse the repository at this point in the history

  5. Return the bracket 

    Looks like I accidentally stole the bracket srry
    @JiliTheSpaceboy
    JiliTheSpaceboy committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    2f54167 View commit details
    Browse the repository at this point in the history

  6. Update render.cpp 

    Co-authored-by: Hleb Valoshka <375gnu@gmail.com>
    @JiliTheSpaceboy @375gnu
    JiliTheSpaceboy and 375gnu committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    646f8b1 View commit details
    Browse the repository at this point in the history