Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lastLocation in LocationTracker is never assigned #614

Closed
agilob opened this issue Sep 19, 2015 · 1 comment
Closed

lastLocation in LocationTracker is never assigned #614

agilob opened this issue Sep 19, 2015 · 1 comment
Labels
Milestone

Comments

@agilob
Copy link
Contributor

agilob commented Sep 19, 2015

But is checked for null value, it always has null value so there is unknown bug in locationtracker

        @TargetApi(Build.VERSION_CODES.JELLY_BEAN_MR2)
        @Override
        public void onLocationChanged(Location loc) {
            if (lastLocation != null &&
                    lastLocation.getLongitude() == loc.getLongitude() &&
                    lastLocation.getLatitude() == loc.getLatitude()) {
                // same location as before, so ignore
                return;
            }

            lastLocationTime = System.currentTimeMillis();
            extLocationListener.onLocationChanged(loc);
        }
@smarek
Copy link
Member

smarek commented Nov 17, 2015

Thanks for finding this, PR is available #641

@smarek smarek added this to the v0.1.37-alpha milestone Nov 17, 2015
@smarek smarek self-assigned this Nov 17, 2015
@smarek smarek closed this as completed in eca9a02 Nov 17, 2015
SecUpwN added a commit that referenced this issue Nov 17, 2015
Fixed duplicate location reports, Closes #614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants