-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EOSF-839] Make use of fingerprinted osf-assets for OSF Preprint logoSharing #503
[EOSF-839] Make use of fingerprinted osf-assets for OSF Preprint logoSharing #503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment. Also, need to remove pathJoin import.
app/services/theme.js
Outdated
type: 'image/png', | ||
width: 1200, | ||
height: 630 | ||
}; | ||
return logo; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also now just:
return {
path: buildProviderAssetPath(config, this.get('id'), 'sharing.png', this.get('isDomain')),
type: 'image/png',
width: 1200,
height: 630
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consistency is good!
c83a3f1
into
CenterForOpenScience:release/post-review-actions
Purpose
Currently, the
og:image
meta tags for OSF Preprint reference to an incorrect asset. This change should fix that to refer to fingerprinted assets in our osf-assets repo.Summary of Changes
In
theme.js
, OSF Preprint'slogo.path
is no longer referencing to assets in ember-osf-preprints. Instead, it is changed to use the samebuildProviderAssetPath
method that builds fingerprinted assets urls for all provider assets.Therefore,
environment.js
is changed to remove theproviders
list that includes information that is no longer necessary for building OSF Preprint assets.Side Effects / Testing Notes
None
Ticket
https://openscience.atlassian.net/browse/EOSF-839
Reviewer Checklist
CHANGELOG.md