Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No-ticket] Fix preprints submit #574

Conversation

alexschiller
Copy link
Contributor

Purpose

Submit is broken. This fixes it.

Summary of Changes

check for empty values for the dirtyfields modal instead of just equality. Remove setting title to ''

Side Effects / Testing Notes

Fix template-lintrc file annoying warning and remove jshint ignore

Ticket

No Ticket

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

Copy link
Contributor

@laurenbarker laurenbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Glad that the deprecation messages will be gone 🥇

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 28.494% when pulling 8b28850 on alexschiller:no-ticket-fix-submit into 4884593 on CenterForOpenScience:release/next-interfaces.

@alexschiller alexschiller merged commit ed5a077 into CenterForOpenScience:release/next-interfaces May 31, 2018
baylee-d pushed a commit to baylee-d/ember-osf-preprints that referenced this pull request Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants