Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][IN-300][Preprints] Prepare the preprint detail page for the preprint/node divorce #593

Conversation

laurenbarker
Copy link
Contributor

This should go on a feature branch for the preprint/node divorce

Purpose

Prepare the preprint detail page for the preprint/node divorce.

Summary of Changes/Side Effects

  • Removed supplementary file browser
  • Removed link to project at bottom of metadata section
  • Added supplemental materials link in header
  • Changed the layout of the header to match what is planned for registrations
  • Removed the logo on the right in the header
  • Updated the loading indicator from spinner to ball scale

supplemental-material-header-sm
supplemental-material-header

Testing Notes

Testing will be difficult without the backend changes.
Should check:

  • Downloading the files

Cases:

  • Node connected
  • Node not connected

Ticket

https://openscience.atlassian.net/browse/IN-300

Notes for Reviewer

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

Add section for supplemental material

Remove OSF project link section
Uncomment explanatory text
Replace spinner loading indicator with ball scale
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 26.411% when pulling e837577 on laurenbarker:improvement/IN-300 into 2dc9703 on CenterForOpenScience:release/next-next-interfaces.

@alexschiller
Copy link
Contributor

this was pulled in elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants