-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][IN-98][Preprints] Submission form #608
Closed
laurenbarker
wants to merge
24
commits into
CenterForOpenScience:release/next-next-interfaces
from
laurenbarker:improvement/IN-98
Closed
[WIP][IN-98][Preprints] Submission form #608
laurenbarker
wants to merge
24
commits into
CenterForOpenScience:release/next-next-interfaces
from
laurenbarker:improvement/IN-98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add section for supplemental material Remove OSF project link section
Uncomment explanatory text
Replace spinner loading indicator with ball scale
Add supplemental materials panel
6 tasks
laurenbarker
force-pushed
the
improvement/IN-98
branch
from
August 3, 2018 13:21
aea8a0a
to
bf95dc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ember-OSF PR: CenterForOpenScience/ember-osf#409
Based on #593
Mockups https://marvelapp.com/6jia421/screen/45305497
Backend PR: CenterForOpenScience/osf.io#8422
TODO
Misc
hasDirtyFields
check which shows the warning model if a user navigates away before submissionSelect a service section
Upload section
Authors section
Discipline section
Supplemental files
Purpose
Changes for the node/preprint divorce submission form changes.
Summary of Changes/Side Effects
ember-collapsible-panel
and removed the modified component we were using in favor of vanillaember-collapsible-panel
jquery-tags-input
withember-tag-input
Testing Notes
This ticket will need to be expanded on.
Ticket
https://openscience.atlassian.net/browse/IN-98
Notes for Reviewer
A lot of the things I did could be improved upon -- just depends how much work you want to put into the refactor.
My main goal, and why I ended up touching so many files, was for the logic to be simple enough to fix bugs. The way it was before would have made it very difficult to fix if anything went wrong. It is also easier to fix bugs/hotfix issues when the components live in the same repository which is why I moved them from ember-osf to preprints (also so we can kill ember-osf ASAP).
The "preview" components don't need to exist as they are only templates that are used in one file. It was just easier to keep them separate when I was moving the preview stuff out of the header component.
Reviewer Checklist
CHANGELOG.md