Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tabs to node addons page #2204

Merged
merged 9 commits into from
May 3, 2024
Merged

Add tabs to node addons page #2204

merged 9 commits into from
May 3, 2024

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented May 1, 2024 •
edited
Loading

  • Ticket: []
  • Feature flag: n/a

Purpose

  • Add tabs to the node addons page for all-addons and just addons that have accounts connected to the project

Summary of Changes

  • Add tabs to node addons page
  • Update some wording
  • Add "Cancel" buttons to pages that have a "Back" button as well
  • Update Addon Service models to use OsfSerializer (for now)
  • Update Addon Service models to use Application Serializer in Mirage (for now)
  • Misc updates needed for AddonCard to work properly

Screenshot(s)

  • All addons (desktop)
    image

  • All addons (mobile)
    image

  • Connected Accounts (desktop)
    image

  • Connected Accounts (mobile)
    image

Side Effects

QA Notes

brianjgeiger
brianjgeiger approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems sane.

@futa-ikeda futa-ikeda merged commit ba1c759 into CenterForOpenScience:feature/addon-services May 3, 2024
9 checks passed
@futa-ikeda futa-ikeda deleted the node-addon-tabs branch May 3, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjgeiger brianjgeiger brianjgeiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@futa-ikeda @brianjgeiger