-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-5170] Addon account reauthorization #2214
[ENG-5170] Addon account reauthorization #2214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions, but nothing blocking.
app/settings/addons/template.hbs
Outdated
<h3 local-class='page-heading'> | ||
{{t 'addons.accountSelect.reconnect-account'}} | ||
</h3> | ||
<AddonsService::AccountSetupManager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually a Manager or is it just an Account Setup component? I know this exists already, but I just noticed and thought it was a bit odd of a name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. This doesn't manage anything, so I can rename this guy to make it a bit more clear
b03be1b
into
CenterForOpenScience:feature/addon-services
Purpose
Summary of Changes
Provider.createAccountForNodeAddon
toProvider.createAuthorizedAccount
for clarityAuthorizedAccount.configuringUser
relationship to the subclasses as the inverse relationships vary based on service typeProvider.setNodeAddonCredentials
Screenshot(s)
Side Effects
QA Notes