[ENG-5170] Addon account reauthorization #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
approved these changes
May 14, 2024
app/settings/addons/template.hbs
Outdated
| <h3 local-class='page-heading'> | ||
| {{t 'addons.accountSelect.reconnect-account'}} | ||
| </h3> | ||
| <AddonsService::AccountSetupManager |
There was a problem hiding this comment.
Is this actually a Manager or is it just an Account Setup component? I know this exists already, but I just noticed and thought it was a bit odd of a name.
There was a problem hiding this comment.
Good point. This doesn't manage anything, so I can rename this guy to make it a bit more clear
futa-ikeda
merged commit b03be1b
into
CenterForOpenScience:feature/addon-services
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
Provider.createAccountForNodeAddontoProvider.createAuthorizedAccountfor clarityAuthorizedAccount.configuringUserrelationship to the subclasses as the inverse relationships vary based on service typeProvider.setNodeAddonCredentialsScreenshot(s)
Side Effects
QA Notes