Styling changes for file versions and share popup #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescdavis
suggested changes
Nov 13, 2017
There was a problem hiding this comment.
Please update to ember-osf@develop (CenterForOpenScience/ember-osf#299 has been merged).
baylee-d
force-pushed
the
feature/style-changes
branch
from
c6a69df
to
fb234b0
Compare
jamescdavis
approved these changes
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There are some final tweaks to be done for parts of Quick Files before sending off to QA. This PR handles some of the style and functionality changes.
Summary of Changes
outsideClickfunction to determine if the user clicks outside of the popup (and toggles accordingly)Ticket
None
Reviewer Checklist
changes described in(don't have initial release yet)CHANGELOG.md