Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EOSF-962] Set revision number back to null on transition #59

Merged
merged 1 commit into from
Jan 5, 2018
Merged

[EOSF-962] Set revision number back to null on transition #59

merged 1 commit into from
Jan 5, 2018

Conversation

baylee-d
Copy link

@baylee-d baylee-d commented Jan 4, 2018

Purpose

Fix revision numbers persisting through route transitions.

Summary of Changes

Add a reset on the controller's routes to change revision back to null.

Ticket

https://openscience.atlassian.net/browse/EOSF-962

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md (don't have initial release yet)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 6.481% when pulling 5d005b4 on baylee-d:feature/fix-version-number-on-transition into 88e73c9 on CenterForOpenScience:develop.

jamescdavis
jamescdavis approved these changes Jan 5, 2018
View reviewed changes
Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jamescdavis jamescdavis merged commit b826065 into CenterForOpenScience:develop Jan 5, 2018
@baylee-d baylee-d deleted the feature/fix-version-number-on-transition branch January 17, 2018 15:53
@jamescdavis jamescdavis added this to the 0.1.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescdavis jamescdavis jamescdavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@baylee-d @coveralls @jamescdavis