Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][IN-98][Ember-OSF] Submission form #409

Conversation

laurenbarker
Copy link
Contributor

@laurenbarker laurenbarker commented Aug 3, 2018

Related Preprints PR: CenterForOpenScience/ember-osf-preprints#608

TODO

  • make sure the file model is correct

Purpose

Changes for the node/preprint divorce submission form changes.

Summary of Changes/Side Effects

  • removed components that were only used in Quickfiles
  • moved components that were only used in Preprints to ember-osf-preprints

Testing Notes

This ticket will need to be expanded on.

Ticket

https://openscience.atlassian.net/browse/IN-98

Notes for Reviewer

Should make sure everything still functions properly on all of the other apps when they update to this version. I'm fairly confident that everything I removed/moved isn't used anywhere else but it would be good to do some light testing.

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

Move preprints components to preprints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants