[ENG-3009][ENG-3087][ENG-2977] Add aria-labels to sharing icons #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
5 tasks
brianjgeiger
commented
Sep 21, 2021
| {{input | ||
| (html-attributes aria-label='Search') |
There was a problem hiding this comment.
This has to be a bare string rather than a translated one due to limitations on ember-component-attributes. Though I suspect this will be merged into ember-osf-web before we get to translating preprints to a new language.
There was a problem hiding this comment.
A bit curious why this didn't work
Suggested change
| (html-attributes aria-label='Search') | |
| (html-attributes aria-label=(t 'eosf.components.search')) |
There was a problem hiding this comment.
brianjgeiger
changed the title
brianjgeiger
changed the title
fabmiz
reviewed
Oct 5, 2021
| {{input | ||
| (html-attributes aria-label='Search') |
There was a problem hiding this comment.
A bit curious why this didn't work
Suggested change
| (html-attributes aria-label='Search') | |
| (html-attributes aria-label=(t 'eosf.components.search')) |
Co-authored-by: Fabrice Mizero <fabrice@cos.io>
fabmiz
pushed a commit
to CenterForOpenScience/ember-osf-preprints
that referenced
this pull request
Oct 5, 2021
## Purpose Fix some more accessibility problems on the preprint detail page ## Summary of Changes/Side Effects <!-- What did you change? Include before/after screenshots or a video/gif if applicable. Do these changes have any unforseen effects (good or bad)?--> ## Testing Notes 1. Update version of ember-osf to fix sharing icons not having aria-labels 2. Remove redundant `id='view-page'` 3. Add expand/collapse aria label to mfr expand/collapse control ## Notes for Reviewer This will need to be yarn updated and ci run after CenterForOpenScience/ember-osf#456 is deployed. Also, this does not fix the MFR iframe issue, which looks to be an MFR problem.
brianjgeiger
added a commit
to CenterForOpenScience/ember-osf-preprints
that referenced
this pull request
Oct 7, 2021
## Purpose Fixes the accessibility problems related to contrast on the Preprints submit/edit page. Some of these changes (`(required)` red in the license picker items) are in CenterForOpenScience/ember-osf#456 but this PR isn't pinned to that, as another preprints PR is already pinned. ## Summary of Changes/Side Effects 1. Darker black for the preprint header preview `<i>` tag 2. Darker red for `(required)` and error messages 3. Darker placeholder text ## Testing Notes Should just need to make sure that above items are passing a11y guidelines. ## Ticket https://openscience.atlassian.net/browse/ENG-2977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes an accessibility problem on the ember preprints discover page (And also another on the preprints create/edit pages)
Summary of Changes/Side Effects
(required)labels for https://openscience.atlassian.net/browse/ENG-2977Testing Notes
This will be tested alongside the ember-osf-preprints PR that this will be linked to.
Ticket
https://openscience.atlassian.net/browse/ENG-3009
https://openscience.atlassian.net/browse/ENG-3087
https://openscience.atlassian.net/browse/ENG-2977
Reviewer Checklist
CHANGELOG.md