-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Need QA Prep] Feature/The Amicable Node-Preprint Divorce [PLAT-555][PLAT-480][PLAT-559][PLAT-561] #8422
Closed
pattisdr
wants to merge
146
commits into
CenterForOpenScience:feature/files-on-anything
from
pattisdr:feature/node-preprint
Closed
[Need QA Prep] Feature/The Amicable Node-Preprint Divorce [PLAT-555][PLAT-480][PLAT-559][PLAT-561] #8422
pattisdr
wants to merge
146
commits into
CenterForOpenScience:feature/files-on-anything
from
pattisdr:feature/node-preprint
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#PLAT-509]Django-guardian for preprint permissions
pattisdr
commented
Jun 29, 2018
LIMIT 1 | ||
) PREPRINT ON TRUE | ||
WHERE (TYPE = 'osf.node' OR TYPE = 'osf.registration' OR TYPE = 'osf.quickfilesnode') | ||
WHERE (TYPE = 'osf.node' OR TYPE = 'osf.registration') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug fix? Seems like this would make quickfile nodes show up in search
- Restore dashes between preprint contributors in search - Annotate preprint result as (Preprint) - Delete unused email templates - Don't index preprints that were withdrawn before becoming public - Don't add affiliated institutions to preprints when formatting preprint - Modify check_spam management command to separate nodes/preprints so if a node is marked as spam, a preprint is not automatially marked. - In migrate_preprint and migrate_node, delete items from the index that have been marked as spam - Don't restrict the queryset when running migrate_preprints, individual migrate_preprint will check whether or not item should be indexed.
- Modify data migration to change both codename and name of renamed permissions. - Remove unnecessary attempts to modify non-existent contributor attributes on user object - Make the contributors method more generic, by defining more class variables on the node and preprint models instead of type checking in the mixin -
pattisdr
force-pushed
the
feature/node-preprint
branch
5 times, most recently
from
July 5, 2018 02:04
2c16b29
to
8d20809
Compare
…ForOpenScience/osf.io into feature/node-preprint
pattisdr
force-pushed
the
feature/node-preprint
branch
from
July 5, 2018 02:58
8d20809
to
05f0403
Compare
…ForOpenScience/osf.io into feature/node-preprint
…only takes in one argument.
pattisdr
force-pushed
the
feature/node-preprint
branch
2 times, most recently
from
July 6, 2018 16:42
beb09da
to
49167e4
Compare
- Modify enqueue_postcommit_task to just run the task while testing.
pattisdr
force-pushed
the
feature/node-preprint
branch
from
July 6, 2018 18:34
49167e4
to
80eb0ba
Compare
Recent updates involve responding to an in-person review w/ Steve and accommodating Erin's DOI work. |
…ForOpenScience/osf.io into feature/node-preprint
…. Shift migrations to depend on latest added (0117_set_is_root). - See if is_quickfiles exists in update_file method (preprints don't have this attribute).
pattisdr
force-pushed
the
feature/node-preprint
branch
from
July 16, 2018 13:33
e65108f
to
d84be3c
Compare
pattisdr
force-pushed
the
feature/node-preprint
branch
from
July 27, 2018 22:16
946865a
to
92154bd
Compare
- Nodes can hold supplemental material for multiple preprints. - Remove migration which added a partial index on one preprint per provider per node, provided node existed. - Project page now can display all the preprints for which the node holds supplemental material, provided the logged in user has permission to view those preprints. - Removes a lot of now unused preprint-related node properties - Email sent to contributors when a user is added to a node that is linked to a preprint lists all the published preprints the node holds supplemental information for. - Remove preprint_url from relations_meta metadata tags since the node has been separated from the preprint. - "preprint" property on the node serializer is true if the node is a supplemental node for a preprint the user can view.
pattisdr
force-pushed
the
feature/node-preprint
branch
from
July 28, 2018 01:49
92154bd
to
446ec83
Compare
@laurenbarker, constraint of one preprint per provider per node removed. |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Removes the dependency of Preprints on Nodes. Nodes can house supplemental files for a preprint, but beyond that, Preprints are completely independent.
Ticket contains:
How to create a preprint in the API
Step 1: Start Preprint
POST http://localhost:8000/v2/preprints/
Required fields are title and provider
Step 2 Upload new file to preprint, or copy file from existing node:
Uploading new file
GET http://localhost:8000/v2/preprints/nmqp6/files/
and thenCopying file from supplementary node
Get "move" link from supplementary node and then POST to move link where resource is the preprint id, action is copy, and provider is osfstorage.
GET http://localhost:8000/v2/nodes/4u3mk/files/osfstorage/
and thenStep 3 - Update preprint to set newly uploaded file as primary file, add subjects if not there already, (supplementary node optional) and publish
Changes
Too many to list, here are some of them.
Admin App
API
v2/preprints/
(title, provider are required fields) 2) Use WB links to upload or move file to created preprint 3) PATCH tov2/preprints/<preprint_id>/
to finish up process.Elastic Search
scripts/remove_after_use/node_preprint_es.py
)Modeling
Preprint File
Legacy UI
Supplemental project attached to withdrawn preprint - status says Withdrawn
Withdrawn preprint still shows up for a user on My Projects page. Is marked as withdrawn.
Published preprints show up on My Projects page
My private preprints still show up on My Projects page
Selecting multiple preprints on My Projects page
Elastic search before migration - 2 preprints 3 projects
Elastic search after migration - 2 preprints 5 projects (2 projects formerly indexed as preprints were reindexed as projects)
Preprint files don't have links, but you can click on preprint link. File detail for preprint page is blocked.
QA Notes
Many many things to test. A lot of Node code was adapted to work for preprints so we want to make sure we didn't break things. Preprints front-end is not addressed here.
To check on Node
To check on preprint
Checking migration
Side Effects
Ticket