-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/APIv2 Node Settings [PLAT-924] #8536
Merged
sloria
merged 20 commits into
CenterForOpenScience:develop
from
pattisdr:feature/node_settings_apiV2
Jul 27, 2018
Merged
Changes from 13 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d741ec8
Begin adding Node Settings to APIv2.
pattisdr e4bde4d
Make sure user is viewing or has WRITE permissions in IsContributor
erinspace 60031ad
Add NodeSettingsUpdateSerializer for updating fields on NodeSettings
erinspace 010492a
Add node settings test file.
pattisdr 0d03e56
Add missed items to IsContributor permission class and NodeSettings s…
pattisdr d5a861d
Add tests for the NodeSettingsSerializer and GET requests
erinspace 98b94b5
Add test for view_only_links relationship
erinspace b6cd5f0
Add APIv2 update tests for NodeSettings.
pattisdr a62f24c
Merge branch 'feature/node_settings_apiV2' of https://github.com/patt…
pattisdr 9c2026e
Add version 2.9 to API and add to serializer context so addons aren't…
pattisdr 2e43308
Expose settings relationship on Node serializer only.
pattisdr ab33946
Modify is_deprecated so only a min_version or max_version can be spec…
pattisdr c21ac61
Add PUT permissions tests for APIv2 NodeSettings.
pattisdr fb7db32
Move method for setting access requests to node model
erinspace a3468e5
Use new access_requests_enabled method on node, add tests for logging
erinspace a6733d0
Check for logging on other node and wiki actions that have associated…
erinspace d74bf6a
Make update methods consistent in passing auth
erinspace bee8d6a
Override to_representation on NodeSettingsUpdateSerializer to use a d…
pattisdr ab17e69
Merge branch 'develop' of https://github.com/CenterForOpenScience/osf…
pattisdr dd681e7
Fix NodeSettings tests.
pattisdr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erinspace pointed out
writeable_method_fields
which allow writes to a SerializerMethodField. We explored this, but ended up opting for an UpdateSerializer for writes, so we could keep our individual field validation. The NodeSettings serializer is tricky because most of the fields do not actually reside on the node.