[Hotfix][PLAT-1014] Fix email write only #8590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 30784
💛 - Coveralls |
Johnetordoff
force-pushed
the
hotfix-fix-email-write-only
branch
from
f065855
to
81c1500
Compare
sloria
reviewed
Jul 30, 2018
| @@ -952,7 +962,7 @@ def test_add_unregistered_contributor_with_fullname( | |||
| project_public.reload() | |||
| assert res.status_code == 201 | |||
| assert res.json['data']['attributes']['unregistered_contributor'] == 'John Doe' | |||
| assert res.json['data']['attributes']['email'] is None | |||
| assert res.json['data']['attributes'].get('email') is None | |||
There was a problem hiding this comment.
Minor: no need for the code to be defensive in tests. Better to be...assertive 😅 ... about what is expected. In other words, if email isn't expected to be in attributes, test that directly.
assert 'email' not in res.json['data']['attributes']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We don't want to show the email for contributors that have just been added.
Changes
QA Notes
If you add a contributor you should see the contributor's email in the response.
Documentation
Not a user facing change,
Side Effects
None that I know of.
Ticket
https://openscience.atlassian.net/browse/PLAT-1014