Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EMB-498][OSF][Collections] Enable search by contributor and by tags. #8943

Conversation

adlius
Copy link
Collaborator

@adlius adlius commented Feb 12, 2019

Purpose

Search by contributors on collections should work.

Changes

In search_fields, we change contributor to contributor.fullname because fullname is a nested attribute in the ES document.
Add tags to the ES document. Update the index upon addition/removal of tags.

Ticket

https://openscience.atlassian.net/browse/EMB-498

@adlius adlius changed the title [EMB-498][OSF] Change search field to contributor.fullname [EMB-498][OSF][Collections] Enable search by contributor and by tags. Feb 12, 2019
Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make all name parts searchable.

api/search/views.py Show resolved Hide resolved
Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jamescdavis jamescdavis merged commit 67b1792 into CenterForOpenScience:develop Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants