Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data entry mockup (contd.) #44

Draft
wants to merge 86 commits into
base: idea/data-entry-mockup
Choose a base branch
from

Conversation

lukavdplas
Copy link
Contributor

This expands the mockup menu for data entry by adding forms for places and objects.

Supported actions

In the source menu:

  • Click "edit" for the first place (the abbey) to see the form for space descriptions
  • Click "edit" for the first object (letter from Radegund) to see the form for letters/objects.

In the form for the abbey:

  • Click the edit button (pencil icon) on the listed political region (Aquitaine)
  • Click "add political region" to see the form for adding a new region in the description. In the form that opens, type in a name. Try typing in Burgundy to add an existing region to the description, or something else to create a new region.
  • In the "structures" section, click the edit button for Poitiers to see an example of the form. This form includes a fancy visualisation of connected structures, which is is not interactive but could be.

Screenshots

screenshot of space description form

screenshot of menu for editing a political region

screenshot of object description form

@lukavdplas lukavdplas linked an issue Mar 21, 2024 that may be closed by this pull request
Copy link
Contributor

@XanderVertegaal XanderVertegaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. I love the fake spinner and the little card warning the user that changing a description here will change it for all other source descriptions as well.

In addition to the(very) minor points in the comments, I noticed that the radio buttons at 'Can we cross-reference this agent with other sources?' are not wired correctly: I can select both. This is just a mock-up, but it will be confusing for the team if they start playing around with it.

<div class="mb-4">
<label class="form-label">Who is described as the (original) sender?</label>
<div class="form-check">
<input type="checkbox" class="form-check-input" checked>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of checkboxes, this should probably become a dropdown menu in the eventual version.

(Out of scope for now, but good to think about: will we allow inline creation of agents? - If not, the user should be able to save a draft version of this object and come back to it later.)

<div class="mb-5">
<h3>Addressee</h3>
<div class="mb-4">
<label class="form-label">Who is describe as the addressee?</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<label class="form-label">Who is describe as the addressee?</label>
<label class="form-label">Who is described as the addressee?</label>

@XanderVertegaal
Copy link
Contributor

Apologies for the accidental push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Mock-up for data entry form
2 participants