Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: varkor <github@varkor.com>
  • Loading branch information
pawroman and varkor committed Jun 10, 2019
1 parent 2c9c978 commit 60ccf89
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/libcore/unicode/unicode.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
try:
# completely optional type hinting
# (Python 2 compatible using comments,
# see: https://mypy.readthedocs.io/en/latest/python2.html)
# see: https://mypy.readthedocs.io/en/latest/python2.html)
# This is very helpful in typing-aware IDE like PyCharm.
from typing import Any, Callable, Dict, Iterable, Iterator, List, Optional, Set, Tuple
except ImportError:
Expand Down Expand Up @@ -95,7 +95,8 @@ class UnicodeFiles(object):
"Cc": ["C"], "Cf": ["C"], "Cs": ["C"], "Co": ["C"], "Cn": ["C"],
}

# this is the surrogate codepoints range (both ends inclusive)
# This is the (inclusive) range of surrogate codepoints.
# These are not valid Rust characters.
# - they are not valid Rust characters
SURROGATE_CODEPOINTS_RANGE = (0xd800, 0xdfff)

Expand All @@ -122,7 +123,7 @@ def fetch_files(version=None):
"""
Fetch all the Unicode files from unicode.org.
This will use cached files (stored in FETCH_DIR) if they exist,
This will use cached files (stored in `FETCH_DIR`) if they exist,
creating them if they don't. In any case, the Unicode version
is always returned.
Expand Down Expand Up @@ -797,7 +798,7 @@ def parse_args():
parser = argparse.ArgumentParser(description=__doc__)
parser.add_argument("-v", "--version", default=None, type=str,
help="Unicode version to use (if not specified,"
" defaults to latest available final release).")
" defaults to latest release).")

return parser.parse_args()

Expand Down

0 comments on commit 60ccf89

Please sign in to comment.