Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing migrations #294

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Add missing migrations #294

merged 1 commit into from
Mar 26, 2024

Conversation

MRamanenkau
Copy link
Contributor

@MRamanenkau MRamanenkau commented Mar 21, 2024

Description

Changes:

  1. Apply the same migrations that were applied in v5.0.1
  2. Plus pallet_contracts::migration::v9::Migration<Runtime>, the absence of which in version 5.0.1 caused the recent incident in Mainnet
  3. Include in CI a check that try-runtime feature can be compiled

There are a few more missing migrations in staking, balances, and society pallets but they will be added later

Types of Changes

  • Tech Debt (Code improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Dependency upgrade (A change in substrate or any 3rd party crate version)

Migrations and Hooks

  • This change requires a runtime migration.
  • Modifies on_initialize
  • Modifies on_finalize

Checklist

  • Change has been tested locally.
  • Change adds / updates tests.
  • Changelog doc updated.

@aie0 aie0 self-requested a review March 25, 2024 16:01
@MRamanenkau MRamanenkau reopened this Mar 25, 2024
@MRamanenkau MRamanenkau reopened this Mar 26, 2024
@MRamanenkau MRamanenkau merged commit f8e9e21 into master Mar 26, 2024
7 checks passed
@MRamanenkau MRamanenkau deleted the hotfix/contracts-migrations branch March 26, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants