Limit number of glTF validation issues #291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #290
glTF tile content is validated with the glTF-Validator. When validating a glTF asset that contains many errors, this can lead to an out-of-memory error. (For example, the GLB in the linked issue would generate roughly 6 million issues...).
The glTF validator offers an option to limit the number of issues that are reported. It's hard to pick a "universally sensible" value for that.
(One critical corner case could be that when the limit is set to
x
, then there may be an asset that generatesx
warnings or infos, and thex+1
th issue would be an 'error', leading to the asset counting as 'valid' even though it isn't...)This PR just adds a fixed
maxIssues: 1000
for now, which prevents the issue. Questions beyond that are:maxContentIssues
for all types of content, but only the glTF Validator currently supports such a 'limit'...)