Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples for breaking changes in v0.17.0 #13

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Jan 22, 2024

Updating samples to account for the breaking change in CesiumGS/cesium-omniverse#599

Should be merged right before the v0.17.0 release

@lilleyse lilleyse self-assigned this Jan 26, 2024
@lilleyse lilleyse force-pushed the imagery-changes branch 2 times, most recently from ff31714 to cb9ca3e Compare January 29, 2024 20:22
@r-veenstra
Copy link
Contributor

I've updated two .usda with the workaround from CesiumGS/cesium-omniverse#607 so that users can still open the samples with the USD Composer 2023.2.2 and see the correct outcome. We can remove this temporary prim once the issue is resolved in a future Composer / Kit release.

@lilleyse
Copy link
Contributor Author

Thanks @r-veenstra, I agree that it's probably the best we can do for now.

Would you mind checking all the sample projects in USD Composer? I did it last week but a lot has changed since. Then this should be good to merge.

@r-veenstra
Copy link
Contributor

r-veenstra commented Jan 31, 2024

Tested all the sample projects. Only tileset clipping is broken because it uses a material approach, however I'm about to update that with a new PR to use a new PolygonRasterOverlay approach

@r-veenstra r-veenstra merged commit 9ecd229 into main Jan 31, 2024
@r-veenstra r-veenstra deleted the imagery-changes branch January 31, 2024 03:02
@lilleyse lilleyse changed the title CesiumImageryPrim -> CesiumIonImageryPrim Update samples for breaking changes in v0.17.0 Jan 31, 2024
@lilleyse
Copy link
Contributor Author

I used this Godbolt example to convert transfom:cesium to translate, rotateXYZ, scale when updating the globe anchor related samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants