Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE completely broken in master #2358

Closed
mramato opened this issue Dec 30, 2014 · 1 comment · Fixed by #2359
Closed

IE completely broken in master #2358

mramato opened this issue Dec 30, 2014 · 1 comment · Fixed by #2359

Comments

@mramato
Copy link
Contributor

mramato commented Dec 30, 2014

Run Cesium Viewer in IE and you'll get the below error. This does not happen in 1.4

RuntimeError: Vertex shader failed to compile.  Compile log: Shader compilation errors
(0, 0): Function 'get2DYPositionFraction' is declared and used but not defined

Error
   at RuntimeError (http://localhost:8080/Source/Core/RuntimeError.js:42:13)
   at createAndLinkProgram (http://localhost:8080/Source/Renderer/ShaderProgram.js:503:17)
   at initialize (http://localhost:8080/Source/Renderer/ShaderProgram.js:689:9)
   at ShaderProgram.prototype._bind (http://localhost:8080/Source/Renderer/ShaderProgram.js:706:9)
   at beginDraw (http://localhost:8080/Source/Renderer/Context.js:1793:9)
   at Context.prototype.draw (http://localhost:8080/Source/Renderer/Context.js:1860:9)
   at DrawCommand.prototype.execute (http://localhost:8080/Source/Renderer/DrawCommand.js:185:9)
   at executeCommand (http://localhost:8080/Source/Scene/Scene.js:1050:13)
   at executeCommands (http://localhost:8080/Source/Scene/Scene.js:1279:17)
   at render (http://localhost:8080/Source/Scene/Scene.js:1377:9)
@kring
Copy link
Member

kring commented Dec 30, 2014

That has to be from #2346, though I don't know why it would only show up on IE. I'll take a look soon.

kring added a commit that referenced this issue Dec 30, 2014
Fixes #2358

A function needed only in 2D mode was not being included in 3D.  Other
browsers were ok with this because the functions that called the missing
one were never called, but IE had a problem with it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants