Fix shader compilation failure in IE11. #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2358 A function needed only in 2D mode was not being included in 3D. Other browsers were ok with this because the functions that called the missing one were never called, but IE had a problem with it.
|
Code looks good to me. @mramato can you test and merge? I don't have a Windows machine handy today. |
|
Thanks @kring. |
mramato
added a commit
that referenced
this pull request
Dec 30, 2014
Fix shader compilation failure in IE11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2358
A function needed only in 2D mode was not being included in 3D. Other
browsers were ok with this because the functions that called the missing
one were never called, but IE had a problem with it.
This change includes the function in 3D as well, which is consistent with Cesium's behavior before #2346.