Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a corner case where unused glTF nodes would cause
Model
to crash at runtime.ModelSceneGraph
keeps an array of runtime nodes that is the same length as the list of nodes in the glTF. However, unused nodes areundefined
entries in this array. The loops inconfigurePipeline
andupdate
weren't filtering out this corner case.This bug was first reported in this forum post, see the thread for an example tileset.