Fix zoomTo bug for scaled models
#10855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @j9liu!
Reviewers, don't forget to make sure that:
|
|
@ptrgags could you give this a review? |
|
@j9liu the code looks good and I can confirm it fixes the problem works locally. The travis build failed due to a network error, so I restarted it. If it passes, I'll merge this |
|
Thanks @j9liu! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10830.
updateBoundingSpherewas only applying the scale to the radius of the model's local bounding sphere, not the center. This didn't matter for many models because their local bounding spheres are(0, 0, 0). However, this clearly results in an incorrect bounding sphere for models whose bounding spheres are "off-center."Local sandcastle from the issue to demonstrate the correct behavior.