Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Model crash that occurs when specular environment maps are unsupported #10859

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

j9liu
Copy link
Contributor

@j9liu j9liu commented Oct 17, 2022

Fixes #10858. To reiterate, many Sandcastles that used image-based lighting were crashing on mobile device browsers that don't support specular environment maps. In ImageBasedLightingStageFS, the function textureIBL would always expect model_iblReferenceframeMatrix to be declared even when specular environment maps were disabled. This PR addresses that bug.

@cesium-concierge
Copy link

Thanks for the pull request @j9liu!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@j9liu
Copy link
Contributor Author

j9liu commented Oct 17, 2022

@lilleyse can you review this when you get the chance?

@lilleyse
Copy link
Contributor

Thanks @j9liu!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants