Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash due to terrain loading race condition #11382

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Jun 30, 2023

Follow up from #11296

Technically after that change, due to this line, it was possible to return a promise which resolves to undefined if a requestTileGeometry request gets throttled by the requestScheduler.

@ggetz ggetz requested a review from jjhembd June 30, 2023 20:56
@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ggetz!

@jjhembd jjhembd merged commit b3d8833 into main Jul 3, 2023
2 checks passed
@jjhembd jjhembd deleted the terrain-crash-fix branch July 3, 2023 14:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants