Use proper type for scratch variables #11700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11685
It is not really "required", and does not solve "problem" (except for that itchy feeling in the head of people who usually use typed languages): The
scratchVariable
that was used either as aCartesian3
or as aQuaternion
has now been split into ascratchCartesian3
andscratchQuaternion
that are used depending on the animatedpath
(i.e. the cartesian for"translation"
and"scale"
, and the quaternion for the"rotation"
).Should this be mentioned in
CHANGES.md
? It seems like something that is "too internal" to be mentioned...I considered to add a unit test - basically consisting of
But none of that is "visible" at the outside: The
runtimeNode["rotation"]
is still aQuaternion
, because the setter inModelRuntimeNode
clones the inputvalue
- which is aCartesian3
, but it does have that.w
component, so ... it happens to work 😬 If anyone has an idea for how to "test" this, I'd add the tests accordingly...