Fix perVertex colors for PolylineGeometry and SimplePolylineGeometry #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etry This was due to a typo in the code (and no matching unit test for it). We were using `perVertex` internally and `colorsPerVertex` for the API. In addition to fixing the typo, I changed it to `colorsPerVertex` to avoid confusion in the future. I also updated tests to make sure everything was what it should be.
|
Looks good. |
pjcozzi
added a commit
that referenced
this pull request
Mar 2, 2015
Fix perVertex colors for PolylineGeometry and SimplePolylineGeometry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was broken due to a typo in the code (and no matching unit test for it). We were using
perVertexinternally andcolorsPerVertexfor the API. In addition to fixing the typo, I changed it tocolorsPerVertexto avoid confusion in the future. I also updated tests to make sure everything was what it should be.This was a regression in 1.6, so we should merge this for 1.7.