Honor windows.devicePixelRatio by default #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cesium now honors `window.devicePixelRatio` by default, which greatly improving performance on mobile devices and high DPI displays by rendering at the browser-recommended resolution. This change also decreases bandwidth usage because we request far fewer tiles when rendering at lower resolutions.
|
Looks good. |
pjcozzi
added a commit
that referenced
this pull request
Nov 21, 2015
Honor windows.devicePixelRatio by default
mramato
added a commit
that referenced
this pull request
Dec 3, 2015
This reintroduces #3233, but now uses the `image-rendering` CSS property to disable smooth scaling and avoid burriness. Since this is a CSS4 property, it's not supported by all browsers (Safari/IE), so we detect if the property is supported and if it isn't, we fallback to full resolution rendering on those browsers so that the image is always crisp.
mramato
added a commit
that referenced
this pull request
Dec 4, 2015
This reintroduces #3233, but now uses the `image-rendering` CSS property to disable smooth scaling and avoid burriness. Since this is a CSS4 property, it's not yet supported by all browsers (Safari/IE), so we detect if the property is supported and if it isn't, we fallback to full resolution rendering on those browsers so that the image is always crisp. The other nice thing about this approach is that it's detect capability and not the browser itself, so when Safari and IE do add support, Cesium will automatically start taking advantage of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honor windows.devicePixelRatio by default
Way back in #1162 (over two years ago), we put in changes to let Cesium render at native screen resolution, ignoring
window.devicePixelRatio. This made sense at the time becauseThe above reasons no longer make sense
Finally, this also greatly reduces bandwidth when devicePixelRatio > 1 because we are sucking down way less terrain and imagery tiles. This is another huge improvement for mobile.