Honor devicePixelRatio take 3 #3288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reintroduces #3233, but now uses the `image-rendering` CSS property to disable smooth scaling and avoid burriness. Since this is a CSS4 property, it's not yet supported by all browsers (Safari/IE), so we detect if the property is supported and if it isn't, we fallback to full resolution rendering on those browsers so that the image is always crisp. The other nice thing about this approach is that it's detect capability and not the browser itself, so when Safari and IE do add support, Cesium will automatically start taking advantage of it.
# Conflicts: # CHANGES.md
# Conflicts: # CHANGES.md
|
I most likely will not be able to look at this until after the 1.17 release. WebGL has been crashing my Mac. I think the fan failed, but need to look into it. |
|
No problem. As long as we can get it merged in early Jan so it has time to sit in master in case before 1.18. |
# Conflicts: # CHANGES.md
|
I'd like to get this into 1.18. The better frame rate on android should also be a big plus for the new cardboard webvr support. |
|
Not sure when my Mac will be fixed. @klim705 let's test this on your machine tomorrow. |
|
It looks alright on my Mac. |
|
Yeap, looks good! Sorry for the delay. |
gberaudo
added a commit
to gberaudo/ol3-cesium
that referenced
this pull request
Mar 31, 2016
See CesiumGS/cesium#3288 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reintroduces #3233, but now uses the
image-renderingCSS property to disable smooth scaling and avoid blurriness. Since this is a CSS4 property, it's not yet supported by all browsers (Safari/IE), so we detect if the property is supported and if it isn't, we fallback to full resolution rendering on those browsers so that the image is always crisp (at the cost of performance).The other nice thing about this approach is that it's detect capability and not the browser itself, so when Safari and IE do add support, Cesium will automatically start taking advantage of it.
Given the previous false start, I'm in no rush to merge this, but I'm fairly confident that this is the right fix and tested out this branch on a variety of devices.
Fixes #3249