Use relative paths in 3d tiles sandcastle #3477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @lilleyse |
pjcozzi
added a commit
that referenced
this pull request
Jan 27, 2016
…le-relative-paths Use relative paths in 3d tiles sandcastle
|
We should not be referencing data in Specs for Sandcastle examples, Please move (or duplicate) the data in |
|
@mramato he explained this in the first comment
|
|
Whoops, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using relative paths instead as suggested in this comment: #3463 (comment)
For now I'm still referencing files in the Specs folder because it will make it easier to manage the data if it's only in one place. Once 3d tiles is more stable, we can copy the data to the Apps folder. This is in the roadmap #3241.