3D Tiles Sandcastle demo #3463
3D Tiles Sandcastle demo #3463
Conversation
|
This didn't require any updates to server.js? I would expect that we should add something like to here: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/server.js#L41-L46 |
Can you add a TODO to #3241, then we'll do this before merging to master to avoid headaches when regenerating the dataset. |
| var canaryWharfUrl = 'http://localhost:8002/tilesets/CanaryWharf/'; | ||
| var seattleUrl = 'http://localhost:8002/tilesets/Seattle/'; | ||
|
|
||
| var city; |
There was a problem hiding this comment.
Minor, but can you rename city to tileset? I started using tileset as the canonical variable name.
Ah thanks for catching that, I made the change to my cleanup branch but not here. |
| @@ -405,7 +405,7 @@ define([ | |||
|
|
|||
| if (owner.debugShowContentBoundingVolume && hasContentBoundingVolume && workaround2657(tile._header.content.boundingVolume)) { | |||
| if (!defined(tile._debugContentBoundingVolume)) { | |||
| tile._debugContentBoundingVolume = tile._boundingVolume.createDebugVolume(Color.BLUE); | |||
| tile._debugContentBoundingVolume = tile._contentBoundingVolume.createDebugVolume(Color.BLUE); | |||
|
Also, please add a TODO to #3241 to integrate the sample CC3D data into this Sandcastle example and to generate the thumbnail. |
|
Any idea why this isn't 11.3? Is this a new issue with Cesium labels? Or something in this branch?
var cartesian = scene.pickPosition(movement.position);
var cartographic = Cesium.Cartographic.fromCartesian(cartesian);
var height = cartographic.height.toFixed(2) + ' m'; |
Or does this have something to do with the 3D tileset? |
|
For the composite example, is the instance and batched tile in the composite tile? Looks like we need to move the debug color selection logic into the composite:
|
| var instancedUrl = 'http://localhost:8080/Specs/Data/Cesium3DTiles/Instanced/InstancedWithBatchTable/'; | ||
| var compositeUrl = 'http://localhost:8080/Specs/Data/Cesium3DTiles/Composite/Composite/'; | ||
| var pointsUrl = 'http://localhost:8080/Specs/Data/Cesium3DTiles/Points/Points/'; | ||
| var washingtonDCUrl = 'http://localhost:8002/tilesets/WashingtonDC/'; |
There was a problem hiding this comment.
Let's remove this and Canary Wharf and Seattle for now.
|
Just those comments. This is great; it will be soooooo useful for testing! |
Not sure.. the console prints the correct values. I'll have to look around some more. |
Working on this now. Will open a PR into this branch shortly. |
…le-server Add MIME types for 3D tile formats
|
This is updated. I changed the organization for debug coloring so that most of the work is now in I'm still not sure why the labeling is weird, I've tried different string combinations and sometimes it works fine, sometimes nothing. |
|
Do the |
|
Just that question. This looks good! |
|
Result of a bad merge, fixed now. |
|
Looks good! |
| scene.debugShowFramesPerSecond = true; | ||
| //viewer.extend(Cesium.viewerCesiumInspectorMixin); | ||
|
|
||
| var tilesetUrl = 'http://localhost:8080/Specs/Data/Cesium3DTiles/Tilesets/Tileset/'; |
There was a problem hiding this comment.
These urls should not be hardcoded and they should not be absolutely. They need to be relative in order to work in all cases and on the Cesium website.
There was a problem hiding this comment.
Yes, this is important. Please use a relative path.
For #3177
I took most of the code from the
Cities.htmlSandcastle demo and made it into3D Tiles.html. I added a dropdown to switch between data sets. Right now they are pulling from theSpecs/Datafolder, but I'm happy to copy them to theApps/SampleDatafolder if that makes more sense.