Fix s3 deploy when branches have same prefix as other branch. #4184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out our deploy step had a nasty bug where branches would collide if they started with the name of another branch, for example `3d-tiles` would try and delete the deployment files for `3d-tiles-transform`. This is because AWS prefixes need to end with a trailing `/` in order to list only child files. So `3d-tiles` would return all files from all branches that start with `3d-tiles`, whereas `3d-tiles/` only gets files from `3d-tiles` as desired.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out our deploy step had a nasty bug where branches would collide if they started with the name of another branch, for example
3d-tileswould try and delete the deployment files for3d-tiles-transform. This is because AWS prefixes need to end with a trailing/in order to list only child files. So3d-tileswould return all files from all branches that start with3d-tiles, whereas3d-tiles/only gets files from3d-tilesas desired.Ones this is merged down into
3d-tilesand related branches, all of the CI processes should finally start to pass.