Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix s3 deploy when branches have same prefix as other branch. #4184

Merged
merged 1 commit into from
Aug 9, 2016
Merged

Fix s3 deploy when branches have same prefix as other branch. #4184

merged 1 commit into from
Aug 9, 2016

Commits on Aug 8, 2016

  1. Fix s3 deploy when branches have same prefix as other branch. 

    Turns out our deploy step had a nasty bug where branches would collide if
they started with the name of another branch, for example `3d-tiles` would
try and delete the deployment files for `3d-tiles-transform`.  This is
because AWS prefixes need to end with a trailing `/` in order to list
only child files.  So `3d-tiles` would return all files from all branches
that start with `3d-tiles`, whereas `3d-tiles/` only gets files from
`3d-tiles` as desired.
    @mramato
    mramato committed Aug 8, 2016
    Configuration menu
    Copy the full SHA
    61a9644 View commit details
    Browse the repository at this point in the history