Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom2D Bug Fix #5421

Merged
merged 4 commits into from
Jun 8, 2017
Merged

Zoom2D Bug Fix #5421

merged 4 commits into from
Jun 8, 2017

Conversation

WilliamKHo
Copy link

@WilliamKHo WilliamKHo commented Jun 5, 2017

Fixes #4898 where zoom would not work in 2D when the Cesium display had height > width

@WilliamKHo WilliamKHo changed the title added bug fix and unit tests Zoom2D Bug Fix Jun 5, 2017
@WilliamKHo
Copy link
Author

bump @hpinkos can you take a look?

@hpinkos
Copy link
Contributor

hpinkos commented Jun 7, 2017

Functionality works! @bagnell can you take a look at the code?

@bagnell
Copy link
Contributor

bagnell commented Jun 8, 2017

I tweaked CHANGES.md because the modified function was private. Otherwise, looks good. Thanks @WilliamKHo!

@bagnell bagnell merged commit ac942a1 into CesiumGS:master Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants