Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE 11 #6169

Merged
merged 2 commits into from
Jan 29, 2018
Merged

Fix IE 11 #6169

merged 2 commits into from
Jan 29, 2018

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Jan 29, 2018

IE 11 seems to be returning Infinity for performance.now() on some systems. This adds an extra level of validation in getTimestamp to make sure the value is finite.

Fixes #6146

IE 11 seems to be returning Infinity for `performance.now()` on some
systems.  This adds an extra level of validation in `getTimestamp` to
make sure the value is finite.

Fixes #6146
@cesium-concierge
Copy link

Signed CLA is on file.

@mramato, thanks for the pull request! Maintainers, we have a signed CLA from @mramato, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@mramato
Copy link
Contributor Author

mramato commented Jan 29, 2018

Update CHANGES

@mramato
Copy link
Contributor Author

mramato commented Jan 29, 2018

@tfili since you are one of the lucky ones this bug shows up on, can you test/review/merge? Thanks.

@mramato mramato requested a review from tfili January 29, 2018 18:14
@tfili
Copy link
Contributor

tfili commented Jan 29, 2018

👍

@tfili tfili merged commit efcaf5f into master Jan 29, 2018
@tfili tfili deleted the fix-ie11 branch January 29, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants