Avoid parameter reassignment in Camera.flyToBoundingSphere and Camera.viewBoundingSphere #8438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @jhnwsk!
Reviewers, don't forget to make sure that:
|
Cloning the offset parameter of adjustBoundingSphereOffset results in no argument reassignment in functions that use it. Because this reassignment is not document and therefore unintentional it prevents confusion when using the Camer api.
jhnwsk
force-pushed
the
do-not-reassign-options-range
branch
from
fd010a9
to
ff104b8
Compare
jhnwsk
changed the title
|
Thanks again for your contribution @jhnwsk! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
emackey
approved these changes
Jan 6, 2020
added 2 commits
January 29, 2020 09:22
|
Thanks for the PR @jhnwsk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloning the offset parameter of adjustBoundingSphereOffset results in no argument reassignment in functions that use it. Because this reassignment is not documented I assume it is not intentional. Avoiding it prevents confusion when using the Camera api.