Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash when creating plane with translation and normal on the Z axis #8576

Merged
merged 3 commits into from
Jan 30, 2020

Conversation

IanLilleyT
Copy link
Contributor

Sandcastle with crash
Sandcastle with fix

When creating the model matrix the code tries to generate an up vector that is different than the normal, and does this by setting the up vector to UNIT_Z. But if the normal itself is UNIT_Z, the problem is still there. So I added another check that sets it to UNIT_X if setting to UNIT_Z failed.

@cesium-concierge
Copy link

Thanks for the pull request @IanLilleyT!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor

hpinkos commented Jan 30, 2020

👍

@hpinkos hpinkos merged commit c3e902a into master Jan 30, 2020
@hpinkos hpinkos deleted the planeGeometryFix branch January 30, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants