Add glTF animation STEP interpolation #8786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @emackey!
Reviewers, don't forget to make sure that:
|
It was fun! How's everyone else's quarantine going so far?
|
Looks great @emackey. Confirmed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for glTF's STEP animation interpolation. It also adds tests for output values of STEP and the existing LINEAR interpolations (previously there were tests for times only, not output values).
Note that the new tests depend on fixes introduced in #8769, so please merge #8769 before reviewing this PR.
STEP interpolation is important to support, because the Blender glTF exporter can end up writing this if there is exactly one keyframe, or if the Blender user has used "Constant" keyframes.